lkml.org 
[lkml]   [2012]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Patch v1 06/10] perf/x86: add support for PEBS Precise Store
From
On Mon, Oct 29, 2012 at 4:40 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2012-10-29 at 16:15 +0100, Stephane Eranian wrote:
>> - if (fll) {
>> + if (fll || fst) {
>> if (sample_type & PERF_SAMPLE_ADDR)
>> data.addr = pebs->dla;
>>
>> @@ -688,6 +731,8 @@ static void __intel_pmu_pebs_event(struct perf_event *event,
>> if (sample_type & PERF_SAMPLE_DSRC) {
>> if (fll)
>> data.dsrc.val = load_latency_data(pebs->dse);
>> + else if (fst)
>> + data.dsrc.val = precise_store_data(pebs->dse);
>> }
>> }
>>
>
> Ah, this is why I guess.. hrm.. ok, n/m then.

Yes, it is. But your proposal and my extension for Precise Store look good too.


\
 
 \ /
  Last update: 2012-10-29 17:41    [W:0.165 / U:1.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site