lkml.org 
[lkml]   [2012]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/14] perf python: Initialize 'page_size' variable
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    The commit 0c1fe6b:

    'perf tools: Have the page size value available for all tools'

    Broke the python binding because the global variable 'page_size' is
    initialized on the main() routine, that is not called when using
    just the python binding, causing evlist.mmap() to fail because it
    expects that variable to be initialized to the system's page size.

    Fix it by initializing it on the binding init routine.

    Reported-by: David Ahern <dsahern@gmail.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-vrvp3azmbfzexnpmkhmvtzzc@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/python.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
    index 9181bf2..a2657fd 100644
    --- a/tools/perf/util/python.c
    +++ b/tools/perf/util/python.c
    @@ -1015,6 +1015,8 @@ PyMODINIT_FUNC initperf(void)
    pyrf_cpu_map__setup_types() < 0)
    return;

    + page_size = sysconf(_SC_PAGE_SIZE);
    +
    Py_INCREF(&pyrf_evlist__type);
    PyModule_AddObject(module, "evlist", (PyObject*)&pyrf_evlist__type);

    --
    1.7.9.2.358.g22243


    \
     
     \ /
      Last update: 2012-10-29 16:41    [W:5.696 / U:3.520 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site