Messages in this thread | | | Date | Mon, 29 Oct 2012 09:46:57 -0400 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH 01/10] xen/pvh: Support ParaVirtualized Hardware extensions. |
| |
On Wed, Oct 24, 2012 at 10:37:45AM +0100, Ian Campbell wrote: > On Tue, 2012-10-23 at 19:12 +0100, Konrad Rzeszutek Wilk wrote: > > diff --git a/include/xen/interface/physdev.h b/include/xen/interface/physdev.h > > index 1844d31..83050d3 100644 > > --- a/include/xen/interface/physdev.h > > +++ b/include/xen/interface/physdev.h > > @@ -274,6 +274,16 @@ struct physdev_dbgp_op { > > } u; > > }; > > > > +#define PHYSDEVOP_map_iomem 30 > > +struct physdev_map_iomem { > > + /* IN */ > > + uint64_t first_gfn; > > + uint64_t first_mfn; > > + uint32_t nr_mfns; > > + uint32_t add_mapping; /* 1 == add mapping; 0 == unmap */ > > I think we would usually have map and unmap as separate ops.
Or an #define as a flag? Say:
#define PHYSDEV_MAP_IOMEM_ADD (1<<1) #define PHYSDEV_MAP_IOMEM_REMOVE (1<<0)
which means that '0' is of course an invalid value and alter the 'add_mapping' to a 'flag' value, as so:
struct physdev_map_iomem { /* IN */ uint64_t first_gfn; uint64_t first_mfn; uint32_t nr_mfns; uint32_t flag; }
| |