Messages in this thread | | | Date | Mon, 29 Oct 2012 17:48:00 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH v3 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent |
| |
On 10/26/2012 03:37 PM, Michal Hocko wrote: > The root cgroup cannot be destroyed so we never hit it down the > mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't > even try to do anything if called for the root. > > This means that mem_cgroup_move_parent doesn't have to bother with the > root cgroup and it can assume it can always move charges upwards. > > Signed-off-by: Michal Hocko <mhocko@suse.cz> > Reviewed-by: Tejun Heo <tj@kernel.org>
I think it would be safer to have this folded in the last patch, to avoid a weird intermediate state (specially for force_empty). Being a single statement, it doesn't confuse review so much.
However, this is also pretty much just a nitpick, do as you prefer.
Reviewed-by: Glauber Costa <glommer@parallels.com>
| |