lkml.org 
[lkml]   [2012]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH V3 07/10] Secure boot: Add a dummy kernel parameter that will switch on Secure Boot mode
    From
    Date
    Hi Josh, 

    於 二,2012-09-25 於 09:08 -0400,Josh Boyer 提到:
    > This forcibly drops CAP_COMPROMISE_KERNEL from both cap_permitted and cap_bset
    > in the init_cred struct, which everything else inherits from. This works on
    > any machine and can be used to develop even if the box doesn't have UEFI.
    >
    > Signed-off-by: Josh Boyer <jwboyer@redhat.com>
    > ---
    > Documentation/kernel-parameters.txt | 7 +++++++
    > kernel/cred.c | 17 +++++++++++++++++
    > 2 files changed, 24 insertions(+)
    >
    > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
    > index 9b2b8d3..93978d5 100644
    ...
    > diff --git a/kernel/cred.c b/kernel/cred.c
    > index de728ac..7e6e83f 100644
    > --- a/kernel/cred.c
    > +++ b/kernel/cred.c
    > @@ -623,6 +623,23 @@ void __init cred_init(void)
    > 0, SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL);
    > }
    >
    > +void __init secureboot_enable()
    > +{
    ...
    > +
    > +/* Dummy Secure Boot enable option to fake out UEFI SB=1 */
    > +static int __init secureboot_enable_opt(char *str)
    > +{
    > + int sb_enable = !!simple_strtol(str, NULL, 0);
    > + if (sb_enable)
    > + secureboot_enable();
    > + return 1;
    > +}
    > +__setup("secureboot_enable=", secureboot_enable_opt);
    > +
    >

    Tahashi has a good idea for use strtobool to allow
    'secureboot_enable=yes' works. Please consider the following change.


    Thanks a lot!
    Joey Lee

    >From f6841a476f3d332fe7b04cb716e0b518cccd5055 Mon Sep 17 00:00:00 2001
    From: Lee, Chun-Yi <jlee@suse.com>
    Date: Mon, 29 Oct 2012 16:36:57 +0800
    Subject: [PATCH] efi: more user-friendly secureboot_enable parameter

    From: Takashi Iwai <tiwai@suse.de>

    Use strtobool can allow 'secureboot_enable=yes', it's more user-friendly.

    Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
    ---
    kernel/cred.c | 5 +++--
    1 files changed, 3 insertions(+), 2 deletions(-)

    diff --git a/kernel/cred.c b/kernel/cred.c
    index 3f5be65..70897a2 100644
    --- a/kernel/cred.c
    +++ b/kernel/cred.c
    @@ -633,9 +633,10 @@ void __init secureboot_enable()
    /* Dummy Secure Boot enable option to fake out UEFI SB=1 */
    static int __init secureboot_enable_opt(char *str)
    {
    - int sb_enable = !!simple_strtol(str, NULL, 0);
    - if (sb_enable)
    + bool sb_enable;
    + if (!strtobool(str, &sb_enable) && sb_enable)
    secureboot_enable();
    +
    return 1;
    }
    __setup("secureboot_enable=", secureboot_enable_opt);
    --
    1.6.0.2



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-10-29 10:41    [W:4.096 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site