Messages in this thread | | | Date | Sat, 27 Oct 2012 09:03:18 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print_regs32() |
| |
On Sat, Oct 27, 2012 at 05:45:49PM +0200, Alessandro Rubini wrote: > >> This function is only used (twice) by the author of it, and the > >> 'prefix' feature is never used. > > I introduced it to shrink some internal code that had a lot of > repetition in the debugfs files implementation. In that context I use > the prefix string. Some of the code had later been submitted, but not > yet all of it. Later work by Davide Ciminaghi moved our MFD user to > the regmap interface, according to maintainer's suggestion (which > however means loosing register names from the debugfs dump).
What is the status of the rest of that code getting accepted?
> > If the parameter isn't being used, please, just delete it. > > It is not currently used by upstream callers, but the function itself > uses it as documented (Documentation/...). I wouldn't remove the > feature and introduce an incompatibility just for this.
But if no one is using it, we can fix the documentation, and just drop it.
thanks,
greg k-h
| |