lkml.org 
[lkml]   [2012]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3 v2] firmware: Add /proc/firmware_path entry to list the firmware paths
    On Thu, Oct 25, 2012 at 11:48:33AM -0700, Greg Kroah-Hartman wrote:
    > On Tue, Oct 23, 2012 at 01:52:55PM +0100, Dimitris Papastamos wrote:
    > > This patch provides the aforementioned procfs file that lists
    > > the default firmware paths that are used during firmware lookup.
    > >
    > > The file contains a white space separated list of paths.
    >
    > Paths can have whitespaces :(
    >
    > How about using the "universal" path seperator of ':' that shells are
    > used to using? Yeah, it gets messy if you have a ':' in a path, but
    > from what I can tell, only the openSUSE build system does looney things
    > like that.

    Sure I can do that, however, could you comment on Ming's comments? Is
    this patchset something we find useful at the moment as regards listing
    and/or updating the firmware path list.

    > > There will be another patch on top of this that adds the functionality
    > > to modify the paths at runtime.
    >
    > Did I miss that patch somewhere?

    That patch is here:
    http://opensource.wolfsonmicro.com/~dp/patches/firmware/0004-firmware-Add-write-support-to-proc-fw_path.patch

    However I've not rebased that patch on top of linux-next and I did not
    send it for review as it seems that it may be a more sensible solution
    to pass this as a kernel parameter.

    Let me know what you think and I'll squeeze some time this weekend
    to look at this.

    Thanks,
    Dimitris


    \
     
     \ /
      Last update: 2012-10-26 12:41    [W:3.776 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site