Messages in this thread | | | Date | Thu, 25 Oct 2012 18:39:41 +0200 | From | Oleg Nesterov <> | Subject | [PATCH 0/1] (Was: freezer: add missing mb's to freezer_count() and freezer_should_skip()) |
| |
Hi Tejun,
On 10/24, Tejun Heo wrote: > Hello, Oleg. > > On Tue, Oct 23, 2012 at 05:39:19PM +0200, Oleg Nesterov wrote: > > > Hmm.... Guess we should drop __ from set_current_state. > > > > Yes. > > > > Or we can change ptrace_stop() and do_signal_stop() to use freezer_do_not_count/ > > freezer_count and remove task_is_stopped_or_traced() from update_if_frozen() > > and try_to_freeze_tasks(). But this means that do_signal_stop() will call > > try_to_freeze() twice, unless we add __freezer_count() which only clears > > PF_FREEZER_SKIP. > > Ooh, I like this idea. If we have a mechanism to mark a task "frozen > enough", it makes sense to use it universally.
Yes, I agree.
Fortunately we already have freezable_schedule() so this patch is really simple.
On top of this series.
Oleg.
| |