lkml.org 
[lkml]   [2012]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 155/193] init: remove CONFIG_EXPERIMENTAL
    From
    On Wed, Oct 24, 2012 at 6:48 AM, Serge Hallyn
    <serge.hallyn@canonical.com> wrote:
    > Quoting Kees Cook (keescook@chromium.org):
    >> This config item has not carried much meaning for a while now and is
    >> almost always enabled by default. As agreed during the Linux kernel
    >> summit, remove it.
    >>
    >> CC: "Eric W. Biederman" <ebiederm@xmission.com>
    >> CC: Serge Hallyn <serge.hallyn@canonical.com>
    >> CC: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
    >> CC: Andrew Morton <akpm@linux-foundation.org>
    >> CC: Frederic Weisbecker <fweisbec@gmail.com>
    >> Signed-off-by: Kees Cook <keescook@chromium.org>
    >> ---
    >> init/Kconfig | 23 ++++++++++-------------
    >> 1 file changed, 10 insertions(+), 13 deletions(-)
    >>
    >> diff --git a/init/Kconfig b/init/Kconfig
    >> index 2bf7b83..4b65c1c 100644
    >> --- a/init/Kconfig
    >> +++ b/init/Kconfig
    >> @@ -220,7 +220,7 @@ config SYSVIPC_SYSCTL
    >>
    >> config POSIX_MQUEUE
    >> bool "POSIX Message Queues"
    >> - depends on NET && EXPERIMENTAL
    >> + depends on NET
    >> ---help---
    >> POSIX variant of message queues is a part of IPC. In POSIX message
    >> queues every message has a priority which decides about succession
    >> @@ -366,7 +366,7 @@ config BSD_PROCESS_ACCT_V3
    >> at <http://www.gnu.org/software/acct/>.
    >>
    >> config TASKSTATS
    >> - bool "Export task/process statistics through netlink (EXPERIMENTAL)"
    >> + bool "Export task/process statistics through netlink"
    >
    > In these cases, should we keep the '(EXPERIMENTAL)' text since it is just
    > a hint to anyone running make menuconfig? I think removing the 'depends on
    > EXPERIMENTAL's is fine, but cases we should leave it (or replace it) as
    > a textual hint, except in cases where we're sure that is no longer the case.

    I covered this in the 000 intro email (https://lkml.org/lkml/2012/10/23/580):

    Some patches remove "(EXPERIMENTAL)" from Kconfig titles when there was
    no "depends on EXPERIMENTAL". I've removed the cases of these where I
    know the maintainer intended it that way. I've left the others in case a
    "depends on EXPERIMENTAL" had been removed in the past and it had been
    accidentally forgotten in the title. If the title is correct as-is,
    just let me know, and I'll drop the patch from my series.


    So, if some of these need to be adjusted, I'm fine with that. I opted
    for aggressive removal in this first series.

    -Kees

    --
    Kees Cook
    Chrome OS Security


    \
     
     \ /
      Last update: 2012-10-24 19:41    [W:4.025 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site