Messages in this thread | | | From | hayeswang <> | Subject | RE: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving | Date | Wed, 24 Oct 2012 13:55:28 +0800 |
| |
Francois Romieu [mailto:romieu@fr.zoreil.com] [...] > > +static void r810x_aldps_disable(struct rtl8169_private *tp) > > +{ > > + rtl_writephy(tp, 0x1f, 0x0000); > > + rtl_writephy(tp, 0x18, 0x0310); > > + msleep(100); > > +} > > rtl8402_hw_phy_config used a msleep(20). Meguesses it won't > hurt, right ?
No, it won't hurt. The delay make suer there is enough time to pause ALDPS.
Best Regards, Hayes
| |