Messages in this thread | | | Date | Wed, 24 Oct 2012 11:56:23 +0300 | Subject | Re: [PATCH 2/2] slab: move kmem_cache_free to common code | From | Pekka Enberg <> |
| |
On Mon, Oct 22, 2012 at 5:05 PM, Glauber Costa <glommer@parallels.com> wrote: > +/** > + * kmem_cache_free - Deallocate an object > + * @cachep: The cache the allocation was from. > + * @objp: The previously allocated object. > + * > + * Free an object which was previously allocated from this > + * cache. > + */ > +void kmem_cache_free(struct kmem_cache *s, void *x) > +{ > + __kmem_cache_free(s, x); > + trace_kmem_cache_free(_RET_IP_, x); > +} > +EXPORT_SYMBOL(kmem_cache_free);
As Christoph mentioned, this is going to hurt performance. The proper way to do this is to implement the *hook* in mm/slab_common.c and call that from all the allocator specific kmem_cache_free() functions.
Pekka
| |