lkml.org 
[lkml]   [2012]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] slab: move kmem_cache_free to common code
    From
    On Mon, Oct 22, 2012 at 5:05 PM, Glauber Costa <glommer@parallels.com> wrote:
    > +/**
    > + * kmem_cache_free - Deallocate an object
    > + * @cachep: The cache the allocation was from.
    > + * @objp: The previously allocated object.
    > + *
    > + * Free an object which was previously allocated from this
    > + * cache.
    > + */
    > +void kmem_cache_free(struct kmem_cache *s, void *x)
    > +{
    > + __kmem_cache_free(s, x);
    > + trace_kmem_cache_free(_RET_IP_, x);
    > +}
    > +EXPORT_SYMBOL(kmem_cache_free);

    As Christoph mentioned, this is going to hurt performance. The proper
    way to do this is to implement the *hook* in mm/slab_common.c and call
    that from all the allocator specific kmem_cache_free() functions.

    Pekka


    \
     
     \ /
      Last update: 2012-10-24 11:41    [W:3.912 / U:0.664 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site