| Date | Tue, 23 Oct 2012 16:11:47 -0700 | Subject | Re: [PATCH 158/193] mm: remove CONFIG_EXPERIMENTAL | From | Kees Cook <> |
| |
On Tue, Oct 23, 2012 at 3:46 PM, David Rientjes <rientjes@google.com> wrote: > On Tue, 23 Oct 2012, Kees Cook wrote: > >> diff --git a/mm/Kconfig b/mm/Kconfig >> index a3f8ddd..679945e 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -1,6 +1,5 @@ >> config SELECT_MEMORY_MODEL >> def_bool y >> - depends on EXPERIMENTAL || ARCH_SELECT_MEMORY_MODEL >> >> choice >> prompt "Memory model" > > This makes ARCH_SELECT_MEMORY_MODEL pointless, why keep it around?
Good point. This seems to trigger much deeper changes. All of these and their logic go away:
arch/arm/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/arm/mach-clps711x/Kconfig: select ARCH_SELECT_MEMORY_MODEL arch/arm64/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/ia64/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/parisc/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/powerpc/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/s390/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/sh/mm/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/sparc/Kconfig:config ARCH_SELECT_MEMORY_MODEL arch/x86/Kconfig:config ARCH_SELECT_MEMORY_MODEL
Along with mm/Kconfig:config SELECT_MEMORY_MODEL and associated logic.
How about we handle this as a phase 2, and for phase 1, I just drop EXPERIMENTAL?
-Kees
-- Kees Cook Chrome OS Security
|