lkml.org 
[lkml]   [2012]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/3] f2fs: move proc files to debugfs
    On Tue, Oct 23, 2012 at 11:20:55AM -0700, Greg KH wrote:
    > Here are 3 patches, moving the proc file usage on f2fs to debugfs.
    >
    > The first one fixes a bug in the gc.h file preventing it from being able
    > to be included by any other files.
    >
    > The second patch moves all current proc file accesses to a single file,
    > removing all #ifdefs from the .c files. This should have been done in
    > the first place.
    >
    > The last file converts the files to use debugfs instead of proc.
    >
    > Note, these patches have been compile tested only, I haven't tested them
    > out, as I haven't had the chance to yet. I'll go do that this afternoon
    > after I catch up on some other pending kernel work.
    >
    > One question, it seems that the proc files show all information for all
    > super blocks in the system, no matter which subdirectory you are reading
    > from in the proc f2fs tree. Is that really what you want? Shouldn't we
    > only be showing the stats of the superblock we are saying we will
    > report? I'll test that later today, and if it really is wrong, will fix
    > the debugfs code up to handle this properly.

    I just tested your patch set, and it looks like I see all partition
    information in each file, no matter what subdir it is in.

    So, do you want this to be broken up per partition/superblock, in a
    subdir, like you intended? Or just 3 files, for all superblocks in the
    system?

    Oh, the third patch is buggy, don't apply it, I got the subdir logic
    wrong, I'll go fix that up now.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2012-10-23 22:01    [W:4.162 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site