Messages in this thread | | | Date | Tue, 23 Oct 2012 17:55:33 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks |
| |
On 10/22, Tejun Heo wrote: > > On Mon, Oct 22, 2012 at 08:34:53PM +0200, Oleg Nesterov wrote: > > > > Hmm. We seem to "leak" PF_NOFREEZE if a kernel thread execs? > > Perhaps do_execve_common() should do set_freezable() before return. > > > > Or, at least, simply clear this flag along with PF_KTHREAD in > > flush_old_exec(). > > Ooh, ouch, definitely. We should clear that. Can you please make a > patch?
Sure... but what do you think is better?
I'd prefer to simply clear PF_NOFREEZE (without set_freezable), but obviously this doesn't look exactly right from cgroup_freezer pov.
Oleg.
| |