Messages in this thread | | | Date | Tue, 23 Oct 2012 16:12:19 +0200 | From | Andrew Jones <> | Subject | Re: [PATCH 1/2] perf header: Fix numa topology printing |
| |
On Tue, Oct 23, 2012 at 10:44:49PM +0900, Namhyung Kim wrote: > Andrew reported that the commit 7e94cfcc9d20 ("perf header: Use pre- > processed session env when printing") regresses the header output. > It was because of a missed string pointer calculation in the loop. > > Reported-by: Andrew Jones <drjones@redhat.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/util/header.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index 7daad237dea5..566b84c695c8 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -1378,6 +1378,8 @@ static void print_numa_topology(struct perf_header *ph, int fd __maybe_unused, > > str = tmp + 1; > fprintf(fp, "# node%u cpu list : %s\n", c, str); > + > + str += strlen(str) + 1; > } > return; > error: > -- > 1.7.9.2 >
works for me
Tested-by: Andrew Jones <drjones@redhat.com>
| |