lkml.org 
[lkml]   [2012]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc
Hi,

On Tue, Oct 23, 2012 at 06:04:53PM +0530, Sekhar Nori wrote:
> On 10/8/2012 6:47 PM, Constantine Shulyupin wrote:
> > From: Constantine Shulyupin <const@MakeLinux.com>
> >
> > Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
> > CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
> > and set MUSB_OTG configuration by default
> > because this configuration options are removed from Kconfig.
> >
> > Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
>
> Queuing this patch for v3.8. Since the config options are removed there
> is no use having code which refers to them. The patch has been tested on
> DM644x and DM365 in both host and gadget mode (I will add this
> information to commit text while committing). Without this patch .mode
> seems to be defaulting to MUSB_UNDEFINED which I think is definitely wrong.

sorry for the delay, this looks ok:

Acked-by: Felipe Balbi <balbi@ti.com>

>
> Thanks,
> Sekhar
>
> >
> > ---
> > arch/arm/mach-davinci/usb.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
> > index f77b953..34509ff 100644
> > --- a/arch/arm/mach-davinci/usb.c
> > +++ b/arch/arm/mach-davinci/usb.c
> > @@ -42,14 +42,8 @@ static struct musb_hdrc_config musb_config = {
> > };
> >
> > static struct musb_hdrc_platform_data usb_data = {
> > -#if defined(CONFIG_USB_MUSB_OTG)
> > /* OTG requires a Mini-AB connector */
> > .mode = MUSB_OTG,
> > -#elif defined(CONFIG_USB_MUSB_PERIPHERAL)
> > - .mode = MUSB_PERIPHERAL,
> > -#elif defined(CONFIG_USB_MUSB_HOST)
> > - .mode = MUSB_HOST,
> > -#endif
> > .clock = "usb",
> > .config = &musb_config,
> > };
> >

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-10-23 15:21    [W:1.633 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site