lkml.org 
[lkml]   [2012]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2] Input: omap4-keypad: Add pinctrl support

    On Tue, 23 Oct 2012 12:45:33 +0200, Linus Walleij wrote:

    > Hm so I have had this idea of runtime PM core helping out
    > with pins, so I could add something like
    >
    > pm_pins_fetch()
    > pm_pins_default()
    > pm_pins_idle()
    > pm_pins_sleep()
    >
    > So if one is using the pin states defined in
    > <linux/pinctrl/pinctrl-state.h> then the PM core can help out in
    > keeping track of the pins and states, and the driver will just tell
    > the PM core what to do and when.
    >
    > Would this fit the bill for everyone's code consolidation needs?
    > It would sure work for us...

    That surely would work but is kind of non-obvious when reading a
    driver's code: that's the problem with bus notifier, they do things a
    bit "behind your back" without you noticing. Having the driver request
    its own pinctrl state, and switch between states upon suspend/resume is
    a lot more explicit, IMO.

    Thomas
    --
    Thomas Petazzoni, Free Electrons
    Kernel, drivers, real-time and embedded Linux
    development, consulting, training and support.
    http://free-electrons.com


    \
     
     \ /
      Last update: 2012-10-23 13:41    [W:4.152 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site