Messages in this thread | | | Date | Tue, 23 Oct 2012 13:29:03 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support |
| |
Hi,
On Tue, Oct 23, 2012 at 12:29:28PM +0200, Linus Walleij wrote: > On Tue, Oct 23, 2012 at 12:23 PM, Thomas Petazzoni > <thomas.petazzoni@free-electrons.com> wrote: > > > > On Tue, 23 Oct 2012 13:03:33 +0300, Felipe Balbi wrote: > > > >> > But it appears that shmobile prefer to get all resources using > >> > bus notifiers. > >> > > >> > So we need to form some kind of consensus ... or live with > >> > the fact that different systems do it different ways. Which will > >> > explode the day we need to use a driver on two systems, > >> > each using the other approach :-) > >> > >> I much prefer having drivers explicitly manage all their resources, > >> which would mean that pinctrl calls need to be done on probe() and, if > >> necessary, during suspend()/resume(). > >> > >> Using bus notifiers for that is quite a hack IMHO. > > > > Agreed. Just like drivers do their ioremap, request_irq and others, > > they should also request their pin resources using the pinctrl API. > > Hiding this behind a bus notifier is not nice. > > So the biggest implementation of the notifier approach to resource > handling is the SH clock thing: > drivers/base/power/clock_ops.c
that's different right ? It's just creating the list of clocks, device drivers still have to call pm_clk_add().
That's ok, I guess, otherwise all struct device would allocate memory which hardly ever used (so far).
-- balbi [unhandled content-type:application/pgp-signature] | |