Messages in this thread | | | From | "Philip, Avinash" <> | Subject | RE: [PATCH 1/4] mtd: nand: omap2: Update nerrors using ecc.strength | Date | Tue, 23 Oct 2012 10:17:55 +0000 |
| |
On Tue, Oct 16, 2012 at 00:26:40, Peter Korsgaard wrote: > >>>>> Philip, Avinash <avinashphilip@ti.com> writes: > > > Update number of errors using nand ecc strength. > > Also add macro definitions BCH8_ERROR_MAX & BCH4_ERROR_MAX > > > Signed-off-by: Philip, Avinash <avinashphilip@ti.com> > > --- > > :100644 100644 5b31386... af511a9... M drivers/mtd/nand/omap2.c > > drivers/mtd/nand/omap2.c | 12 ++++++++---- > > 1 files changed, 8 insertions(+), 4 deletions(-) > > > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > > index 5b31386..af511a9 100644 > > --- a/drivers/mtd/nand/omap2.c > > +++ b/drivers/mtd/nand/omap2.c > > @@ -111,6 +111,9 @@ > > #define ECCCLEAR 0x100 > > #define ECC1 0x1 > > > +#define BCH8_MAX_ERROR 8 /* upto 8 bit coorectable */ > > +#define BCH4_MAX_ERROR 4 /* upto 4 bit correctable */ > > First 'correctable' misspelled.
I will correct it
> > I don't personally think these defines improve readability very much > compared to to just using 4/8, though.
Thought of removing magic numbers & provide information also.
Thanks Avinash
> > -- > Bye, Peter Korsgaard >
| |