Messages in this thread | | | Date | Tue, 23 Oct 2012 13:03:33 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support |
| |
Hi,
On Tue, Oct 23, 2012 at 12:04:01PM +0200, Linus Walleij wrote: > On Tue, Oct 23, 2012 at 11:35 AM, Benoit Cousson <b-cousson@ti.com> wrote: > > On 10/23/2012 11:13 AM, Linus Walleij wrote: > > >> So Sourav, please tell us a bit about your plans for this > >> and other drivers! > > > > Yeah, this idea is to handle pinctrl from all the drivers, and > > potentially change the mode during suspend when it is relevant. > > I'm leaning toward the same approach for ux500. > > But it appears that shmobile prefer to get all resources using > bus notifiers. > > So we need to form some kind of consensus ... or live with > the fact that different systems do it different ways. Which will > explode the day we need to use a driver on two systems, > each using the other approach :-)
I much prefer having drivers explicitly manage all their resources, which would mean that pinctrl calls need to be done on probe() and, if necessary, during suspend()/resume().
Using bus notifiers for that is quite a hack IMHO.
-- balbi [unhandled content-type:application/pgp-signature] | |