Messages in this thread | | | Date | Tue, 23 Oct 2012 11:29:44 +0900 | Subject | Re: [PATCH for-v3.7 2/2] slub: optimize kmalloc* inlining for GFP_DMA | From | JoonSoo Kim <> |
| |
2012/10/22 Christoph Lameter <cl@linux.com>: > On Sun, 21 Oct 2012, Joonsoo Kim wrote: > >> kmalloc() and kmalloc_node() of the SLUB isn't inlined when @flags = __GFP_DMA. >> This patch optimize this case, >> so when @flags = __GFP_DMA, it will be inlined into generic code. > > __GFP_DMA is a rarely used flag for kmalloc allocators and so far it was > not considered that it is worth to directly support it in the inlining > code. > >
Hmm... but, the SLAB already did that optimization for __GFP_DMA. Almost every kmalloc() is invoked with constant flags value, so I think that overhead from this patch may be negligible. With this patch, code size of vmlinux is reduced slightly.
| |