lkml.org 
[lkml]   [2012]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH] gpiolib: add gpio get direction support
From
On Mon, Oct 22, 2012 at 3:44 PM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:

> Add gpio_get_direction() for checking the current direction of a gpio.
> Returns 1 for input, 0 for output, or negative error.
> Gpio drivers need to set the gpio_chip .get_direction callback for this
> functionality, otherwise gpio_get_direction() returns error.

OK...

> If the .get_direction callback is set, then gpiolib will use it
> for showing correct gpio direction in sysfs and debug. If not set
> then it will work the old way; e.g. guessing everything is input
> until direction is set.

If the driver cannot report the direction setting you *could*
cache the result of all calls to gpio_direction_output()
and gpio_direction_input() somewhere. But I don't know
if it's a good idea.

Anyway, if the callback is only called internally in the GPIOlib
why are you making the function public to the entire
kernel like this?

> include/asm-generic/gpio.h
> +extern int gpio_get_direction(unsigned gpio);

> include/linux/gpio.h
> +static inline int gpio_get_direction(unsigned gpio)
> +{
> + return -ENOSYS;
> +}
> +

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2012-10-23 01:01    [W:0.054 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site