lkml.org 
[lkml]   [2012]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 02/06] input/rmi4: Core files
On 10/10/2012 08:06 PM, Joe Perches wrote:
> On Thu, 2012-10-11 at 02:49 +0000, Christopher Heiny wrote:
>> Joe Perches wrote:
> []
>>>> + list_for_each_entry(entry, &data->rmi_functions.list, list)
>>>> + if (entry->irq_mask)
>>>> + process_one_interrupt(entry, irq_status,
>>>> + data);
>>>
>>> style nit, it'd be nicer with braces.
>>
>> I agree with you, but checkpatch.pl doesn't. :-(
>
> Sure it does.
>
> $ cat t.c
> {
> list_for_each_entry(entry, &data->rmi_functions.list, list) {
> if (entry->irq_mask)
> process_one_interrupt(entry, irq_status, data);
> }
> }
> $ ./scripts/checkpatch.pl --strict -f t.c
> total: 0 errors, 0 warnings, 0 checks, 7 lines checked
>
> t.c has no obvious style problems and is ready for submission.

I stand corrected. Thanks!


\
 
 \ /
  Last update: 2012-10-23 00:21    [W:0.084 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site