Messages in this thread | | | Date | Tue, 23 Oct 2012 00:56:41 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [rfc 0/2] Introducing VmFlags field into smaps output |
| |
On Tue, Oct 23, 2012 at 12:50:48AM +0400, Pavel Emelyanov wrote: > On 10/22/2012 11:29 PM, Andrew Morton wrote: > > On Mon, 22 Oct 2012 23:14:52 +0400 > > Cyrill Gorcunov <gorcunov@openvz.org> wrote: > > > >> Hi guys, during c/r sessions we've found that there is no way at > >> the moment to fetch some VMA associated flags, such as mlock() > >> and madvise(), thus the patches in this series intorduce new field > >> into "smaps" output called VmFlags where all flags associated with > >> the particular VMA is shown in two letter mnemonic. > >> > >> Strictly speaking for c/r we only need mlock/madvise bits but it > >> has been said that providing just a few flags looks somehow inconsistent. > >> So all flags are here now. > >> > >> Please review. Comments and complains are quite welcome! > > > > Sigh, it's still a pretty nasty-looking interface. Better ideas are > > welcomed. > > Maybe just a string of two-letter short names like > > VmFlags: rd wr sh sr > > ? > > I.e. in a way flags line looks in cpuinfo file.
Yup, I think this will be shorter and more agreeable.
| |