Messages in this thread | | | From | "Yann E. MORIN" <> | Subject | Re: [PATCH v2] menuconfig: Replace CIRCLEQ by list_head-style lists. | Date | Mon, 22 Oct 2012 21:38:25 +0200 |
| |
Benjamin, Michal, All,
On Sunday 21 October 2012 Benjamin Poirier wrote: > From: Benjamin Poirier <bpoirier@suse.de> > > sys/queue.h and CIRCLEQ in particular have proven to cause portability > problems (reported on Debian Sarge, Cygwin and FreeBSD)
Benjamin,
Thank you for working on this! :-)
> Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Tested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Tested-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net> > Signed-off-by: Benjamin Poirier <bpoirier@suse.de> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > > Changes v1-v2: > * integrate the patch/suggestion from Yann to fix problems related to the > usage of list.h with xconfig/c++ > * "new" keyword > * offsetof redefinition > * silly #endif placement mistake
Michal,
Any more comments on this patch?
If not, then I would suggest to push it for inclusion before 3.7 is released (I believe it can go in, as it is a bugfix, not a new feature).
Regards, Yann E. MORIN.
-- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
| |