| Date | Mon, 22 Oct 2012 19:11:24 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH v5 15/18] Aggregate memcg cache values in slabinfo |
| |
On 10/19/2012 11:50 PM, Christoph Lameter wrote: > On Fri, 19 Oct 2012, Glauber Costa wrote: > >> + >> +/* >> + * We use suffixes to the name in memcg because we can't have caches >> + * created in the system with the same name. But when we print them >> + * locally, better refer to them with the base name >> + */ >> +static inline const char *cache_name(struct kmem_cache *s) >> +{ >> + if (!is_root_cache(s)) >> + return s->memcg_params->root_cache->name; >> + return s->name; >> +} > > Could we avoid this uglyness? You can ID a slab cache by combining a memcg > pointer and a slabname. > But that is not what I want.
What I want is to show the cache by its root name in memcg-specific slabinfo.
|