Messages in this thread | | | Date | Sat, 20 Oct 2012 15:57:38 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 3/3] workqueue: remove unused argument of wq_worker_waking_up() |
| |
On Sun, Oct 21, 2012 at 01:30:07AM +0900, Joonsoo Kim wrote: > Commit 63d95a91 ('workqueue: use @pool instead of @gcwq or @cpu where > applicable') changes an approach to access nr_running. > Thus, wq_worker_waking_up() doesn't use @cpu anymore. > Remove it and remove comment related to it. > > Signed-off-by: Joonsoo Kim <js1304@gmail.com>
I'm not sure whether I wanna remove or add WARN_ON_ONCE() on it. That part has gone through some changes and seen some bugs. Can we please do the following instead at least for now?
if (!(worker->flags & WORKER_NOT_RUNNING)) { WARN_ON_ONCE(worker->pool->gcwq->cpu != cpu); atomic_inc(get_pool_nr_running(worker->pool)); }
Thanks.
-- tejun
| |