lkml.org 
[lkml]   [2012]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault.
On Fri, 19 Oct 2012 10:10:16 +0100
Will Deacon <will.deacon@arm.com> wrote:

> On Thu, Oct 18, 2012 at 11:05:02PM +0100, Andrew Morton wrote:
> > On Wed, 17 Oct 2012 16:54:02 +0100
> > Will Deacon <will.deacon@arm.com> wrote:
> >
> > > On x86 memory accesses to pages without the ACCESSED flag set result in the
> > > ACCESSED flag being set automatically. With the ARM architecture a page access
> > > fault is raised instead (and it will continue to be raised until the ACCESSED
> > > flag is set for the appropriate PTE/PMD).
> > >
> > > For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
> > > setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
> > > be called for a write fault.
> > >
> > > This patch ensures that faults on transparent hugepages which do not result
> > > in a CoW update the access flags for the faulting pmd.
> >
> > Confused. Where is the arm implementation of update_mmu_cache_pmd()?
>
> Right at the end of this patch, which was posted to the ARM list yesterday:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-October/126387.html

I received and then merged a patch which won't compile!

Ho hum. I'll drop
mm-thp-set-the-accessed-flag-for-old-pages-on-access-fault.patch and
shall assume that you'll sort things out at the appropriate time.



\
 
 \ /
  Last update: 2012-10-19 21:21    [W:0.068 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site