Messages in this thread | | | Date | Fri, 19 Oct 2012 09:31:39 -0300 | Subject | Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations | From | Ezequiel Garcia <> |
| |
On Thu, Oct 18, 2012 at 7:46 PM, David Rientjes <rientjes@google.com> wrote: > On Thu, 18 Oct 2012, Ezequiel Garcia wrote: > >> This field was being used to store size allocation so it could be >> retrieved by ksize(). However, it is a bad practice to not mark a page >> as a slab page and then use fields for special purposes. >> There is no need to store the allocated size and >> ksize() can simply return PAGE_SIZE << compound_order(page). >> >> Cc: Pekka Penberg <penberg@kernel.org> > > Is Pekka Penberg the long distant cousin of Pekka Enberg? :) You should > probably cc the author of slob, Matt Mackall <mpm@selenic.com>, on slob > patches. >
Ouch! ;-)
I found another typo so I'll just re-send the whole patchset.
Thanks for the review!
Ezequiel
| |