lkml.org 
[lkml]   [2012]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus_open()
On Fri, Oct 12, 2012 at 01:22:42PM -0700, K. Y. Srinivasan wrote:
> -errorout:
> - hv_ringbuffer_cleanup(&newchannel->outbound);
> - hv_ringbuffer_cleanup(&newchannel->inbound);
> +error1:
> + spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);
> + list_del(&open_info->msglistentry);
> + spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
> +
> +error0:

It's better to give the labels meaningful names like error_del and
error_pages instead of GW-BASIC numbers.

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-10-18 12:21    [W:0.070 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site