Messages in this thread | | | Date | Thu, 18 Oct 2012 12:46:25 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/3] Drivers: hv: Cleanup error handling in vmbus_open() |
| |
On Fri, Oct 12, 2012 at 01:22:42PM -0700, K. Y. Srinivasan wrote: > -errorout: > - hv_ringbuffer_cleanup(&newchannel->outbound); > - hv_ringbuffer_cleanup(&newchannel->inbound); > +error1: > + spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); > + list_del(&open_info->msglistentry); > + spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); > + > +error0:
It's better to give the labels meaningful names like error_del and error_pages instead of GW-BASIC numbers.
regards, dan carpenter
| |