Messages in this thread | | | Subject | Re: [RFC PATCH 1/5] irq_work: Move irq_work_raise() declaration/default definition to arch headers | From | Steven Rostedt <> | Date | Mon, 15 Oct 2012 16:02:09 -0400 |
| |
On Mon, 2012-10-15 at 17:11 +0100, Catalin Marinas wrote: > On 12 October 2012 19:09, Frederic Weisbecker <fweisbec@gmail.com> wrote: > > diff --git a/arch/arm/include/asm/irq_work.h b/arch/arm/include/asm/irq_work.h > > new file mode 100644 > > index 0000000..f1bffa2 > > --- /dev/null > > +++ b/arch/arm/include/asm/irq_work.h > > @@ -0,0 +1 @@ > > +#include <asm-generic/irq_work.h> > > diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h > > new file mode 100644 > > index 0000000..f1bffa2 > > --- /dev/null > > +++ b/arch/arm64/include/asm/irq_work.h > > @@ -0,0 +1 @@ > > +#include <asm-generic/irq_work.h> > > Just add generic-y += irq_work.h to arch/*/include/asm/Kbuild to avoid > creating new files. >
BTW, is there any rational reason that the include path lookup doesn't just check for the files in include/asm-generic after looking in arch/*/include/asm?
Really, the best way would be just to add the default asm files into include/asm-generic and be done with it. I hate the fact that we need to touch every arch for every generic default file.
I'd be willing to take a look at fixing this too, when I get a chance.
-- Steve
| |