Messages in this thread | | | Date | Mon, 15 Oct 2012 18:57:56 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 6/9] uprobes: flush cache after xol write |
| |
On 10/14, Rabin Vincent wrote: > > Flush the cache so that the instructions written to the XOL area are > visible. > > Signed-off-by: Rabin Vincent <rabin@rab.in> > --- > kernel/events/uprobes.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index ca000a9..8c52f93 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -1246,6 +1246,7 @@ static unsigned long xol_get_insn_slot(struct uprobe *uprobe, unsigned long slot > offset = current->utask->xol_vaddr & ~PAGE_MASK; > vaddr = kmap_atomic(area->page); > arch_uprobe_xol_copy(&uprobe->arch, vaddr + offset); > + flush_dcache_page(area->page); > kunmap_atomic(vaddr);
I agree... but why under kmap_atomic?
Oleg.
| |