Messages in this thread | | | Date | Sat, 13 Oct 2012 12:22:21 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 14/22] hostfs: drop vmtruncate |
| |
> +++ b/fs/hostfs/hostfs_kern.c > @@ -848,9 +848,11 @@ int hostfs_setattr(struct dentry *dentry, struct iattr *attr) > attr->ia_size != i_size_read(inode)) { > int error; > > - error = vmtruncate(inode, attr->ia_size); > - if (err) > - return err; > + error = inode_newsize_ok(inode, attr->ia_size); > + if (error) > + return error; > + > + truncate_setsize(inode, attr->ia_size);
The inode_change_ok call here is superflous, it's already done by inode_change_ok at the beginning of the function. Even if that wasn't done doing it aftet set_attr() would be too late anyway.
| |