Messages in this thread | | | From | Catalin Marinas <> | Date | Sat, 13 Oct 2012 11:17:46 +0100 | Subject | Re: [PATCH 00/25] asm-generic: Convert all to use Kbuild file |
| |
Hi Steven,
On 13 October 2012 03:26, Steven Rostedt <rostedt@goodmis.org> wrote: > Recently I suggested to someone that was adding a new asm file that > currently only contained an x86 change to add a header in all archs > that was just a wrapper to point to the asm-generic version. I suggested > this because that's the way we use to do it and just to refresh my > memory, I looked at div64.h in a few archs and saw that was the case. > > After having the change done and just after finishing testing it, I was > notified that the "proper" way of doing this is to add it to the > > arch/*/include/asm/Kbuild > > file, as 'generic-y += foo.h' and it will reference the asm-generic > file automatically. Well it would have been nice if I knew this before > and wasn't confused by seeing the incorrect method.
Since you are cleaning this up already, could you please merge these patches into your series:
https://lkml.org/lkml/2012/10/11/291
The first patch adds support for generic-y in the new arch/*/include/uapi/asm/Kbuild file, followed by few patches to convert three architectures. There will probably be more to convert after -rc1.
Thanks.
-- Catalin
| |