Messages in this thread | | | Date | Fri, 12 Oct 2012 12:01:00 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 5/6] net: calxedaxgmac: rework transmit ring handling |
| |
On 10/12/2012 11:28 AM, Ben Hutchings wrote: > On Fri, 2012-10-12 at 10:15 -0500, Rob Herring wrote: >> From: Rob Herring <rob.herring@calxeda.com> >> >> Only generate tx interrupts on every ring size / 4 descriptors. Move the >> netif_stop_queue call to the end of the xmit function rather than >> checking at the beginning. > [...] > > The hardware should also interrupt if the TX ring becomes empty; does it > do that?
Yes, with the "tx buffer unavailable" bit DMA_INTR_ENA_TUE. It is not a per descriptor interrupt.
However, I just noticed I missed part of this patch to actually enable tx descriptor interrupt. New version coming.
Rob
| |