Messages in this thread | | | Date | Fri, 12 Oct 2012 20:48:56 +0530 | Subject | Re: [PATCH V2 2/3] dmaengine: dw_dmac: Enhance device tree support | From | Viresh Kumar <> |
| |
On 12 October 2012 20:28, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
>> + if (last_dw) { >> + if ((last_bus_id == param) && (last_dw == dw)) >> + return false; >> + }
> Just came to my mind. > dw can't be NULL, can't it? > Then > if (last_dw) { > ... > } > is unneeded.
dw can't be but last_dw can be, which we are making NULL when we find a channel :)
You are already drunk.
-- viresh
| |