Messages in this thread | | | Date | Thu, 11 Oct 2012 15:38:56 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH v4 04/14] kmem accounting basic infrastructure |
| |
On Thu 11-10-12 12:11:19, Michal Hocko wrote: > On Mon 08-10-12 14:06:10, Glauber Costa wrote:
> > + cgroup_lock(); > > + mutex_lock(&set_limit_mutex); > > + if (!memcg->kmem_accounted && val != RESOURCE_MAX) { > > Just a nit but wouldn't memcg_kmem_is_accounted(memcg) be better than > directly checking kmem_accounted?
OK, I see that jump lable patch changes this and we set activated inside the conditional so kmem_accounted check catches both flags. That could be changed to memcg_kmem_is_activated in that patch but what ever. -- Michal Hocko SUSE Labs
| |