lkml.org 
[lkml]   [2012]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 085/133] drm/i915: prevent possible pin leak on error path
    Date
    3.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eugeni Dodonov <eugeni.dodonov@intel.com>

    commit ab3951eb74e7c33a2f5b7b64d72e82f1eea61571 upstream.

    We should not hit this under any sane conditions, but still, this does not
    looks right.

    Reported-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    CC: Chris Wilson <chris@chris-wilson.co.uk>
    CC: Daniel Vetter <daniel.vetter@ffwll.ch>
    Reviewed-by: Chris Wlison <chris@chris-wilson.co.uk>
    Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/i915/intel_display.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/i915/intel_display.c
    +++ b/drivers/gpu/drm/i915/intel_display.c
    @@ -6167,7 +6167,7 @@ static int intel_gen7_queue_flip(struct
    default:
    WARN_ONCE(1, "unknown plane in flip command\n");
    ret = -ENODEV;
    - goto err;
    + goto err_unpin;
    }

    ret = intel_ring_begin(ring, 4);



    \
     
     \ /
      Last update: 2012-10-11 03:21    [W:2.360 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site