lkml.org 
[lkml]   [2012]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 037/133] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion
    Date
    3.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------


    From: Florian Fainelli <florian@openwrt.org>

    [ Upstream commit 0b836ddde177bdd5790ade83772860940bd481ea ]

    Commit 36a1211970193ce215de50ed1e4e1272bc814df1 (netprio_cgroup.h:
    dont include module.h from other includes) made the following build
    error on ixp4xx_hss pop up:

    CC [M] drivers/net/wan/ixp4xx_hss.o
    drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')'
    before string constant
    drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')'
    before string constant
    drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')'
    before string constant
    drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')'
    before string constant
    make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1

    This was previously hidden because ixp4xx_hss includes linux/hdlc.h which
    includes linux/netdevice.h which includes linux/netprio_cgroup.h which
    used to include linux/module.h. The real issue was actually present since
    the initial commit that added this driver since it uses macros from
    linux/module.h without including this file.

    Signed-off-by: Florian Fainelli <florian@openwrt.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/wan/ixp4xx_hss.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wan/ixp4xx_hss.c
    +++ b/drivers/net/wan/ixp4xx_hss.c
    @@ -10,6 +10,7 @@

    #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

    +#include <linux/module.h>
    #include <linux/bitops.h>
    #include <linux/cdev.h>
    #include <linux/dma-mapping.h>



    \
     
     \ /
      Last update: 2012-10-11 02:02    [W:4.213 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site