Messages in this thread | | | Date | Wed, 10 Oct 2012 07:43:15 -0700 | Subject | Re: [PATCH 2/3] x86, mm: Don't clear page table if next range is ram | From | Yinghai Lu <> |
| |
On Wed, Oct 10, 2012 at 6:41 AM, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > On Tue, Oct 09, 2012 at 06:00:12PM -0700, Yinghai Lu wrote: >> On Tue, Oct 9, 2012 at 8:46 AM, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: >> >> + !e820_any_mapped(addr & PAGE_MASK, next, 0)) >> > >> > What is the 0 parameter for? >> >> any type > > OK, which means that it either should have a #define for it, or at least > a comment, like: > > 0 /* any type */ > > as this would make it clear at first glance what it is - without having > to dive in e820_any_mapped function to determine that.
yes, we should add E820_ANY_TYPE. and update e820_any_mapped to use it.
will address that later in another patch.
| |