lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 42/49] vfs: allow setxattr to retry once on ESTALE errors
    Date
    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    ---
    fs/xattr.c | 23 ++++++++++++++---------
    1 file changed, 14 insertions(+), 9 deletions(-)

    diff --git a/fs/xattr.c b/fs/xattr.c
    index 588455b..ba286ba 100644
    --- a/fs/xattr.c
    +++ b/fs/xattr.c
    @@ -364,16 +364,21 @@ SYSCALL_DEFINE5(setxattr, const char __user *, pathname,
    {
    struct path path;
    int error;
    + unsigned int try = 0;
    + unsigned int lookup_flags = LOOKUP_FOLLOW;

    - error = user_path(pathname, &path);
    - if (error)
    - return error;
    - error = mnt_want_write(path.mnt);
    - if (!error) {
    - error = setxattr(path.dentry, name, value, size, flags);
    - mnt_drop_write(path.mnt);
    - }
    - path_put(&path);
    + do {
    + error = user_path_at(AT_FDCWD, pathname, lookup_flags, &path);
    + if (error)
    + break;
    + error = mnt_want_write(path.mnt);
    + if (!error) {
    + error = setxattr(path.dentry, name, value, size, flags);
    + mnt_drop_write(path.mnt);
    + }
    + path_put(&path);
    + lookup_flags |= LOOKUP_REVAL;
    + } while (retry_estale(error, try++));
    return error;
    }

    --
    1.7.11.4


    \
     
     \ /
      Last update: 2012-10-02 13:41    [W:4.032 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site