Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 03/15] cfq-iosched: Rename "service_tree" to "st" | Date | Mon, 01 Oct 2012 16:52:13 -0400 |
| |
Vivek Goyal <vgoyal@redhat.com> writes:
> At quite a few places we use the keyword "service_tree" and I feel that > names in CFQ are already very long and they need to be shortened a bit > where appropriate. > > So this patch just renames "service_tree" to "st" at most of the places. > No functionality change.
NACK.
> - struct cfq_rb_root service_trees[2][3]; > - struct cfq_rb_root service_tree_idle; > + struct cfq_rb_root sts[2][3]; > + struct cfq_rb_root st_idle;
Honestly, who looks at sts and thinks "service trees?"
| |