lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 03/15] cfq-iosched: Rename "service_tree" to "st"
    Date
    Vivek Goyal <vgoyal@redhat.com> writes:

    > At quite a few places we use the keyword "service_tree" and I feel that
    > names in CFQ are already very long and they need to be shortened a bit
    > where appropriate.
    >
    > So this patch just renames "service_tree" to "st" at most of the places.
    > No functionality change.

    NACK.

    > - struct cfq_rb_root service_trees[2][3];
    > - struct cfq_rb_root service_tree_idle;
    > + struct cfq_rb_root sts[2][3];
    > + struct cfq_rb_root st_idle;

    Honestly, who looks at sts and thinks "service trees?"


    \
     
     \ /
      Last update: 2012-10-01 23:41    [W:2.581 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site