| Date | Mon, 1 Oct 2012 16:05:19 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver() |
| |
Hi,
On Mon, Oct 01, 2012 at 01:47:17PM +0300, Andy Shevchenko wrote: > On Thu, 2012-09-27 at 10:40 +0300, Felipe Balbi wrote: > > On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote: > > > From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > > > > > > commit log would be great. > Will do. > > > > static struct platform_driver dw_driver = { > > > + .probe = dw_probe, > > > > probe's in __init section. This is wrong. You need to change probe > > __devinit. > Have you checked this one > 0272e93f364eac1a30f2831adcaca3dd633d5f14 > > Or might be I missed something?
My bad, missed that one. Looks like I need to update my local branch.
Reviewed-by: Felipe Balbi <balbi@ti.com>
-- balbi [unhandled content-type:application/pgp-signature] |