Messages in this thread Patch in this message | | | Date | Sun, 8 Jan 2012 23:26:09 -0800 | From | tip-bot for Namhyung Kim <> | Subject | [tip:perf/core] perf kmem: Fix a memory leak |
| |
Commit-ID: 1b22859d4320d472a7a51ff4a43f62b0578469de Gitweb: http://git.kernel.org/tip/1b22859d4320d472a7a51ff4a43f62b0578469de Author: Namhyung Kim <namhyung@gmail.com> AuthorDate: Sun, 8 Jan 2012 02:25:29 +0900 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Sun, 8 Jan 2012 13:27:54 -0200
perf kmem: Fix a memory leak
The 'str' should be freed when sort_dimension__add() failed too.
Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1325957132-10600-5-git-send-email-namhyung@gmail.com Signed-off-by: Namhyung Kim <namhyung@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-kmem.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c index 7a9b5c5..39104c0 100644 --- a/tools/perf/builtin-kmem.c +++ b/tools/perf/builtin-kmem.c @@ -647,6 +647,7 @@ static int setup_sorting(struct list_head *sort_list, const char *arg) break; if (sort_dimension__add(tok, sort_list) < 0) { error("Unknown --sort key: '%s'", tok); + free(str); return -1; } }
| |