lkml.org 
[lkml]   [2012]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] dmatest: store correct thread count in dmatest_add_channel()
Ping?

regards,
dan carpenter

On Thu, Nov 24, 2011 at 02:47:34PM +0300, Dan Carpenter wrote:
> The original code added 1 to the thread_count, but the intent was to
> add += cnt.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 2b8661b..24225f0 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
> }
> if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
> cnt = dmatest_add_threads(dtc, DMA_PQ);
> - thread_count += cnt > 0 ?: 0;
> + thread_count += cnt > 0 ? cnt : 0;
> }
>
> pr_info("dmatest: Started %u threads using %s\n",
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-01-09 12:19    [W:0.049 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site