Messages in this thread Patch in this message | | | From | Gilad Ben-Yossef <> | Subject | [RFC PATCH v2 6/9] agp: avoid using on_each_cpu hard coded ret value | Date | Sun, 8 Jan 2012 15:32:26 +0200 |
| |
on_each_cpu always returns a hard coded return code of zero.
Removing all tests based on this return value saves run time cycles for compares and code bloat for branches.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Reviewed-by: Michal Nazarewicz <mina86@mina86.com> CC: David Airlie <airlied@linux.ie> --- drivers/char/agp/generic.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c index b072648..b6a6f6f 100644 --- a/drivers/char/agp/generic.c +++ b/drivers/char/agp/generic.c @@ -1329,8 +1329,7 @@ static void ipi_handler(void *null) void global_cache_flush(void) { - if (on_each_cpu(ipi_handler, NULL, 1) != 0) - panic(PFX "timed out waiting for the other CPUs!\n"); + on_each_cpu(ipi_handler, NULL, 1); } EXPORT_SYMBOL(global_cache_flush); -- 1.7.0.4
| |