lkml.org 
[lkml]   [2012]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2012.2] fs: symlink restrictions on sticky directories
On Sat, Jan 07, 2012 at 10:55:48AM -0800, Kees Cook wrote:
> v2012.2:
> - Change sysctl mode to 0600, suggested by Ingo Molnar.
> - Rework CONFIG logic to split code from default behavior.
> - Renamed sysctl to have a "sysctl_" prefix, suggested by Andrew Morton.

All the sysctl / CONFIG logic seems very complex. Why not make it
a module parameter instead? It can be easily changed at boot time
(specify kernel.insecure_symlinks=1 on the kernel command line) and,
with a mode of 0600, can be modified at runtime too.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."


\
 
 \ /
  Last update: 2012-01-08 12:47    [W:0.396 / U:3.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site