Messages in this thread | | | Date | Mon, 9 Jan 2012 10:17:03 +0800 | From | Richard Zhao <> | Subject | Re: [RFC PATCH v3 3/5] pinctrl: imx: add pinctrl imx driver |
| |
On Mon, Jan 09, 2012 at 10:08:51AM +0800, Shawn Guo wrote: > On Sun, Jan 08, 2012 at 09:05:44PM +0800, Richard Zhao wrote: > > > +enum imx_imx53_pinctrl_pads { > > > + MX53_GPIO_19 = 0, > > > + MX53_KEY_COL0 = 1, > > > + MX53_KEY_ROW0 = 2, > > > + MX53_KEY_COL1 = 3, > > > + MX53_KEY_ROW1 = 4, > > > + MX53_KEY_COL2 = 5, > > > + MX53_KEY_ROW2 = 6, > > ... > > Why not describe it in dts and make this file generic for imx? > > One node for one pad, > > Doing this will bloat the device tree dramatically. Actually I had > a patch doing so before the pinctrl subsystem was born, but it > concerned Grant a lot for that reason and thus died. are you against describing pad in dts or one node per pad? one node per pad is just a tip to extend pad property, to support other features (pinconf in your word). > > > it'll be easy to extend pad properties. You know > > the pad may set pull up/down, open drain, drive strenth, daisy chain etc. > > The features have to be supported, to make your model usefull. > > > As Aisheng mentioned, the pinconf support will be added later. I expect pinconf come together, and get a ready-to-use patch series.
Thanks Richard > > -- > Regards, > Shawn > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
| |