Messages in this thread | | | Date | Sat, 7 Jan 2012 16:18:33 +0530 | Subject | Re: [PATCH] backlight: lcd: add driver for raster-type lcd's with gpio controlled panel reset | From | Thomas Abraham <> |
| |
Dear Mr. Han,
On 6 January 2012 07:46, Jingoo Han <jg1.han@samsung.com> wrote: > Hi, Thomas. [...]
>> obj-$(CONFIG_LCD_PLATFORM) += platform_lcd.o >> +obj-$(CONFIG_LCD_PWRCTRL) += lcd_pwrctrl.o > Can you remove unnecessary space? > Please use <tab><space><space><space> instead of <space><tab><space><space><space> > between PWRCTRL) and += lcd_.
Ok. I will fix that.
>> [...] >> +static struct platform_driver lcd_pwrctrl_driver = { >> + .driver = { >> + .name = "lcd-pwrctrl", >> + .owner = THIS_MODULE, >> + .of_match_table = of_match_ptr(lcd_pwrctrl_match), >> + }, >> + .probe = lcd_pwrctrl_probe, >> + .remove = lcd_pwrctrl_remove, >> + .suspend = lcd_pwrctrl_suspend, >> + .resume = lcd_pwrctrl_resume, > Please use 'struct dev_pm_ops'.
Ok.
>> +}; >> + >> +static int __init lcd_pwrctrl_init(void) >> +{ >> + return platform_driver_register(&lcd_pwrctrl_driver); >> +} >> + >> +static void __exit lcd_pwrctrl_cleanup(void) >> +{ >> + platform_driver_unregister(&lcd_pwrctrl_driver); >> +} >> + >> +module_init(lcd_pwrctrl_init); >> +module_exit(lcd_pwrctrl_cleanup); > Use module_platform_driver(lcd_pwrctrl_driver). > It can make the code simpler.
Ok. Thanks for your review Mr. Han. I will do the required changes.
Regards, Thomas. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |