lkml.org 
[lkml]   [2012]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/6] x86: initial support for sta2x11
From
Date
On Sat, 2012-01-07 at 09:22 +0100, Alessandro Rubini wrote:
> > or __func__
> I don't understand. No size? Or you typoed and meant pr_fmt defined above?

I meant that outputting __func__ (in this case
sta2x11_new_instance) doesn't gain much useful
information and generally isn't necessary.

> >> + uint32_t v[2]; /* used as a string... */
> > less than pretty.
> Sure. But it's informative. Do you prefer a union?

Not really.




\
 
 \ /
  Last update: 2012-01-07 11:09    [W:0.327 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site